Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-2671] change GCS import test file #2704

Merged
merged 1 commit into from Dec 29, 2021
Merged

[SW-2671] change GCS import test file #2704

merged 1 commit into from Dec 29, 2021

Conversation

krasinski
Copy link
Member

the old file is no longer available and the test fails
that file is coming from some official public dataset and is not ideal as that's not a CSV but some other format and the resulting dataframe doesn't make much sense, but I think that's not that bad given that test just checks if some file coming from GCS can be used

Copy link
Contributor

@kanech kanech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@krasinski krasinski merged commit ba9dd5b into master Dec 29, 2021
@krasinski krasinski deleted the bk/SW-2671 branch December 29, 2021 15:09
krasinski added a commit that referenced this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants