[SW-2700] Add spline_orders to Tests Covering Parameter Propagation to H2OGAMMOJOModel #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o H2OGAMMOJOModel
kanech
reviewed
Apr 11, 2022
| @@ -102,6 +102,7 @@ class MOJOParameterTestSuite extends FunSuite with SharedH2OTestContext with Mat | |||
| .setNumKnots(Array(5, 5)) | |||
| .setBs(Array(1, 1)) | |||
| .setScale(Array(.5, .5)) | |||
| .setSplineOrders(Array(-1, -1)) | |||
There was a problem hiding this comment.
Just a question, are those values (-1, -1) meaningful ones?
There was a problem hiding this comment.
These values haven't been selected to improve performance algorithm, but are valid according to the tests on H2O-3 side:
https://github.com/h2oai/h2o-3/pull/6090/files#diff-4340a0b6fcce0ae9216a6d99f650d45af3f198370c43a422a9f7056707c104e1R233
There was a problem hiding this comment.
Well, I can't judge if combination of Bs, NumKnots and SplineOrders is a meaningful or not, but regarding the interface extension, this is OK (straightforward).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spline_ordersis a new parameter introduced to H2O-3. The tests covering parameter propagation toH2OGAMMOJOModelare currently failing, since the parameter on the algorithm is not set, H2OGAMMOJOModel contians a value was set by H2O-3 backend.