Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-2754] Expose splinesNonNegative parameter on H2OGAM #2831

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Conversation

mn-mikke
Copy link
Collaborator

The parameter is introduced in auto-generated code of SW API. This PR introduces boolean array type for the new parameter since the first time that such a type is used in SW API.

Related PR to H2O-3 repository: h2oai/h2o-3#6336

Genereted files:

Copy link
Member

@krasinski krasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mn-mikke mn-mikke merged commit 6b6a94f into master Oct 27, 2022
@mn-mikke mn-mikke deleted the mn/SW-2754 branch October 27, 2022 10:42
mn-mikke added a commit that referenced this pull request Oct 27, 2022
* [SW-2754] Expose splinesNonNegative parameter on H2OGAM

* Ignore parameter value comparison on MOJO models

(cherry picked from commit 6b6a94f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants