[SW-407] Make Configuration consistent #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow to get and set all properties at run-time at Scala API - allow to get and set all properties at run-time at Python API - remove set_flatfile option in python which isn't defined anywhere in Scala backend - sort definition of configuration properties everywhere in the same order - This change does not change names of existing configuration so all existing configuration works just fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just technical task which brings nothing new, just makes all the setters and getters consistent amongst scala and python
allow to get and set all properties at run-time at Scala API
allow to get and set all properties at run-time at Python API
remove set_flatfile option in python which isn't defined anywhere in Scala backend
sort definition of configuration properties everywhere in the same order
This change does not change names of existing configuration so all existing configuration works just fine