Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-513] Upgrade to Gradle 4.1 #362

Merged
merged 2 commits into from Aug 8, 2017
Merged

[SW-513] Upgrade to Gradle 4.1 #362

merged 2 commits into from Aug 8, 2017

Conversation

jakubhava
Copy link
Contributor

@jakubhava jakubhava commented Aug 7, 2017

Here's the Gradle Change log https://docs.gradle.org/current/release-notes.html

It contains speed improvements for Scala builds

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.0.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-bin.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be -all

Copy link
Contributor Author

@jakubhava jakubhava Aug 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, this is what you get by ./gradlew wrapper --gradle-version=4.1 so should be correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-all contains source code - it is handy if you are debugging something. Try to import the project in idea, it will recommend it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't know that, will fix it. Thanks for the tip!

@jakubhava jakubhava merged commit a6ad699 into master Aug 8, 2017
@jakubhava jakubhava deleted the jh/jira/sw-513 branch August 8, 2017 07:26
mmalohlava pushed a commit that referenced this pull request Aug 23, 2017
* [SW-513] Upgrade to Gradle 4.1

(cherry picked from commit a6ad699)
mmalohlava pushed a commit that referenced this pull request Aug 23, 2017
* [SW-513] Upgrade to Gradle 4.1

(cherry picked from commit a6ad699)
@DinukaH2O DinukaH2O mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants