Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-683] Fix starting H2OContext on Databricks #544

Merged
merged 1 commit into from Jan 26, 2018
Merged

Conversation

jakubhava
Copy link
Contributor

@jakubhava jakubhava commented Jan 23, 2018

We are using internal Spark API available inside package org.spark_project.jetty to register new tabs, however this API(class) is not available on Databricks - they are using regular jetty for this in org.eclipse.jetty (this is even more complicated by the fact that we are shadowing the jetty)

We have several options here:

  1. Add also org.spark_project.jetty to assembly jar and Sparkling Water core dependencies so it's available on the Databricks and in create actually 2 variants of methods attachHandler where one would use the method from regular jetty and one from spark jetty and they would be invoked based on the current environment ( Databricks or not)

Also, we couldn't use features for downloading full and partial logs in case of Databricks since it's again using different paths and API for these handlers. So we can again disable obtaining logs on Databricks.

I have this PR prepared and tested, we can go with this variant, however, I prefer the version implemented in this PR which is 2)

  1. The second option is to simply not add Sparkling Water UI tab in case of Databricks.

The second option is definitely cleaner regarding the code and dependencies in spark assembly ( since we need to provide org.apache.spark-core to make those org.spark_project classes available and these classes might collide with the same classes in some environment`

The first option is more ugly, however, gives at least basic Sparkling Water UI to DBC users.

I still prefer the simple variant implemented in this PR. We can always implement the first when there is demand for it until then, keep the code cleaner.

What do you think @mmalohlava, please?

@rgabo
Copy link

rgabo commented Jan 24, 2018

@jakubhava we've run into the exact same issue last night. I'm glad to see that a PR is available to address the issue. We can build and test the fix ourselves and let you know.

@jakubhava
Copy link
Contributor Author

Let me merge this change as it's always easy to implement the second approach. Right now this will just unblock the DBC users in a easy way

@jakubhava jakubhava merged commit 7b14829 into master Jan 26, 2018
@jakubhava jakubhava deleted the jh/jira/sw-683 branch January 26, 2018 07:02
jakubhava added a commit that referenced this pull request Jan 26, 2018
jakubhava added a commit that referenced this pull request Jan 26, 2018
jakubhava added a commit that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants