Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ARM MacOS build #5662

Merged
merged 2 commits into from Sep 11, 2023
Merged

Fix ARM MacOS build #5662

merged 2 commits into from Sep 11, 2023

Conversation

krasinski
Copy link
Member

No description provided.

mn-mikke
mn-mikke approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

valenad1
valenad1 approved these changes Sep 11, 2023
View reviewed changes
Copy link

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krasinski krasinski merged commit 424b2dd into master Sep 11, 2023
1 of 3 checks passed
@krasinski krasinski deleted the fix-arm-mac-build branch September 11, 2023 14:35
krasinski added a commit that referenced this pull request Oct 13, 2023
@krasinski
Fix ARM MacOS build (#5662)
2d9b49a 
* Fix ARM MacOS build

* add rosetta 2 comment

(cherry picked from commit 424b2dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mn-mikke mn-mikke mn-mikke approved these changes

@valenad1 valenad1 valenad1 approved these changes

@wendycwong wendycwong Awaiting requested review from wendycwong wendycwong is a code owner

@tomasfryda tomasfryda Awaiting requested review from tomasfryda tomasfryda is a code owner

@maurever maurever Awaiting requested review from maurever maurever is a code owner

@syzonyuliia syzonyuliia Awaiting requested review from syzonyuliia syzonyuliia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krasinski @mn-mikke @valenad1