Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-5670] Add Spark 3.5 support #5664

Merged
merged 6 commits into from
Oct 25, 2023
Merged

[GH-5670] Add Spark 3.5 support #5664

merged 6 commits into from
Oct 25, 2023

Conversation

krasinski
Copy link
Member

@krasinski krasinski commented Oct 3, 2023 •
edited

closes #5670

@mn-mikke
Copy link
Collaborator

mn-mikke commented Oct 3, 2023

The change looks good time, but please also make changes in :

  • py-scoring/README.rst
  • py/README.rst

and rebuild testing image

@mn-mikke
Copy link
Collaborator

mn-mikke commented Oct 3, 2023

Can create issue and link it with this pr?

@krasinski krasinski added the next major release Goes into Major release label Oct 10, 2023
@krasinski krasinski changed the title Add Spark 3.5 support [GH-5670] Add Spark 3.5 support Oct 10, 2023
@mn-mikke mn-mikke mentioned this pull request Oct 18, 2023
Merged
mn-mikke
mn-mikke reviewed Oct 24, 2023
View reviewed changes
gradle-spark3.5.properties Outdated
fabricK8sClientVersion=6.4.1
executorOverheadMemoryOption=spark.executor.memoryOverhead
driverOverheadMemoryOption=spark.driver.memoryOverhead
supportedPythonVersions=3.8 3.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will need to add Python 3.10 and 3.11

mn-mikke
mn-mikke approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I would great to build new image and run tests before we merge it.

@krasinski krasinski merged commit 9713dfd into master Oct 25, 2023
2 of 3 checks passed
@krasinski krasinski deleted the add-spark-3-5-support branch October 25, 2023 16:01
ispringer pushed a commit to evergage/sparkling-water that referenced this pull request Apr 11, 2024
@krasinski @ispringer
[h2oaiGH-5670] Add Spark 3.5 support (h2oai#5664)
c5f7fea 
* Add Spark 3.5 support

* fix py docs

* add py 3.10 3.11

* Update Docker Image Version

* rowencoder expression encoder fix

---------

Co-authored-by: h2o-ops <h2o-ops@h2o.ai>
(cherry picked from commit 9713dfd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mn-mikke mn-mikke mn-mikke approved these changes

@wendycwong wendycwong Awaiting requested review from wendycwong wendycwong is a code owner

@tomasfryda tomasfryda Awaiting requested review from tomasfryda tomasfryda is a code owner

@valenad1 valenad1 Awaiting requested review from valenad1 valenad1 is a code owner

@maurever maurever Awaiting requested review from maurever maurever is a code owner

@syzonyuliia syzonyuliia Awaiting requested review from syzonyuliia syzonyuliia is a code owner

Assignees
No one assigned
Labels
next major release Goes into Major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Spark 3.5 support
2 participants
@krasinski @mn-mikke