Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-5676][GH-5679][GH-5619] Add support for Python 3.10 & 3.11 #5677

Merged
merged 12 commits into from Oct 24, 2023

Conversation

krasinski
Copy link
Member

@krasinski krasinski commented Oct 17, 2023

closes #5676 closes #5679 closes #5619

Copy link

@tomasfryda tomasfryda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @krasinski !

@mn-mikke
Copy link
Collaborator

@krasinski Can you also add support for python 3.11 in this PR? It will save you one image build. I think you will need to ignore tests for python 3.10.

@tomasfryda
Copy link

@mn-mikke python 3.12 is already out (https://docs.python.org/3/whatsnew/3.12.html). Would it make sense to include it here as well?

@mn-mikke
Copy link
Collaborator

@tomasfryda We would need to add the support for 3.12 in h2o first. Also there is no pyspark version that would support 3.12. This is the latest: https://pypi.org/project/pyspark/

@krasinski krasinski changed the title [GH-5676] Add support for Python 3.10 [GH-5676] Add support for Python 3.10 & 3.11 Oct 20, 2023
@krasinski krasinski changed the title [GH-5676] Add support for Python 3.10 & 3.11 [GH-5676][GH-5679][GH-5619] Add support for Python 3.10 & 3.11 Oct 20, 2023
@mn-mikke
Copy link
Collaborator

mn-mikke commented Oct 20, 2023

Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@krasinski krasinski merged commit 342fa82 into master Oct 24, 2023
1 of 2 checks passed
@krasinski krasinski deleted the add-support-for-python-3-10 branch October 24, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.11 Add support for Python 3.10 Support for Python 3.10 in H2O Packages
3 participants