Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-5720] Add AIC/Loglikelihood metrics to MetricsTestSuite #5721

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

krasinski
Copy link
Member

closes #5720

Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krasinski krasinski merged commit b3bef8b into master Mar 28, 2024
2 of 3 checks passed
@krasinski krasinski deleted the aic-loglikelihood-5720 branch March 28, 2024 17:15
krasinski added a commit that referenced this pull request Mar 28, 2024
* fix metrics generation (#5718)

(cherry picked from commit 3af804b)

* [GH-5720] Add AIC/Loglikelihood metrics to MetricsTestSuite

(cherry picked from commit b3bef8b)
krasinski added a commit that referenced this pull request Apr 8, 2024
* fix metrics generation (#5718)

(cherry picked from commit 3af804b)

* [GH-5720] Add AIC/Loglikelihood metrics to MetricsTestSuite (#5721)

* fix metrics generation (#5718)

(cherry picked from commit 3af804b)

* [GH-5720] Add AIC/Loglikelihood metrics to MetricsTestSuite

(cherry picked from commit b3bef8b)

* [GH-5720] fix H2oGridSearchTestSuite NaN != NaN

* [GH-5720] fix H2oGridSearchTestSuite NaN != NaN

* aic/loglikelihood optional to be backwards compatible

* fix metrics in test_gridsearch.py

* fix test_mojo.py nan == nan
krasinski added a commit that referenced this pull request Apr 8, 2024
* fix metrics generation (#5718)

(cherry picked from commit 3af804b)

* [GH-5720] Add AIC/Loglikelihood metrics to MetricsTestSuite (#5721)

* fix metrics generation (#5718)

(cherry picked from commit 3af804b)

* [GH-5720] Add AIC/Loglikelihood metrics to MetricsTestSuite

(cherry picked from commit b3bef8b)

* [GH-5720] fix H2oGridSearchTestSuite NaN != NaN

* [GH-5720] fix H2oGridSearchTestSuite NaN != NaN

* aic/loglikelihood optional to be backwards compatible

* fix metrics in test_gridsearch.py

* fix test_mojo.py nan == nan

(cherry picked from commit edbd884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIC/Loglikelihood metrics generation problems
2 participants