[SW-727] Improve method for downloading H2O logs #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalohlava
reviewed
Feb 21, 2018
| // Skip nodes that aren't healthy, since they are likely to cause the entire process to hang. | ||
| try { | ||
| if (node.isHealthy) { | ||
| val g = new GetLogsFromNode |
There was a problem hiding this comment.
interesting i would expect new GetLogsFromNode(i).doIt().bytes()
There was a problem hiding this comment.
Me too, but current H2O API does not allow that and I wanted to limit the scope of this change just to SW
mmalohlava
reviewed
Feb 21, 2018
| private def zipLogs(results: Array[Array[Byte]], clientResult: Array[Byte], topDir: String, destination: URI): URI = { | ||
| assert(H2O.CLOUD._memary.length == results.length, "Unexpected change in the cloud!") | ||
| val l = results.map(_.length).sum | ||
|
|
mmalohlava
previously approved these changes
Feb 21, 2018
jakubhava
commented
Feb 22, 2018
| destination | ||
| } | ||
|
|
||
| /** Zip the H2O logs and return them as byte array */ |
There was a problem hiding this comment.
Wrong comment, we return the path to the downloaded logs
|
thanks @mmalohlava ! |
jakubhava
force-pushed
the
jh/jira/sw-727
branch
from
ef97953
to
2edfe7f
Compare
jakubhava
added a commit
that referenced
this pull request
Feb 22, 2018
(cherry picked from commit d46f3d9)
jakubhava
added a commit
that referenced
this pull request
Feb 22, 2018
(cherry picked from commit d46f3d9)
jakubhava
added a commit
that referenced
this pull request
Feb 22, 2018
(cherry picked from commit d46f3d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.