Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-775] Fix link to updated location of development documentation #631

Merged
merged 3 commits into from Mar 21, 2018

Conversation

ABartzGit
Copy link

No description provided.

@jakubhava
Copy link
Contributor

Instead of pointing to sources, I would Point the link to the latest generated documentation. In case if master - to latest nightly, in case of rel branch, to latest version of doc for this release.

I can have a look on it, thanks!

@jakubhava
Copy link
Contributor

So, for
master -> https://s3.amazonaws.com/h2o-release/sparkling-water/master/latest.html
rel-2.3 -> http://docs.h2o.ai/sparkling-water/2.3/latest-stable/doc/index.html
rel-2.2 -> http://docs.h2o.ai/sparkling-water/2.2/latest-stable/doc/index.html
rel-2.1 -> http://docs.h2o.ai/sparkling-water/2.1/latest-stable/doc/index.html
rel-2.0 -> http://docs.h2o.ai/sparkling-water/2.0/latest-stable/doc/index.html

@angela0xdata Could you please create pull requests with changes with these links?

@jakubhava
Copy link
Contributor

Also as a side-note -> it would be good to go over all links to SW documentation here http://docs.h2o.ai/h2o/latest-stable/index.html and ensure we point to the newly generated documentation. Right now some don't work, some still point to the sources

@ABartzGit
Copy link
Author

ABartzGit commented Mar 21, 2018

It would be good to go over all links to SW documentation here http://docs.h2o.ai/h2o/latest-stable/index.html

That link does not point to the current doc site. (Notice that it is missing the Sparkling Water User Guide.) Let me look into why the download site points to an older version of the docs site.

@jakubhava
Copy link
Contributor

@angela0xdata oki, I didn't know that http://docs.h2o.ai/h2o/latest-stable/index.html is not the major documentation dispatch page. Either way, it is still online and some people may use it to access Sparkling Water docs. Would be good to make it work anyway. What do you think?

But let's mainly focus on the links update up there in this PR. Could you please do the PRs? That would help a lot!

@ABartzGit
Copy link
Author

Yes, I was working on this when I noticed the bad link issue (that you pointed out), and I just fixed that for the h2o-3 nightly build. Will finish this issue today.

@jakubhava
Copy link
Contributor

perfect, thanks a ton @angela0xdata!

@ABartzGit ABartzGit added the docs label Mar 21, 2018
Copy link
Contributor

@jakubhava jakubhava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angela0xdata!

@jakubhava
Copy link
Contributor

Feel free to merge whenever you want

@ABartzGit ABartzGit merged commit 74fe287 into master Mar 21, 2018
@ABartzGit ABartzGit deleted the SW-775 branch March 21, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants