Add theme switch #105
Add theme switch #105
Conversation
Mathanraj-Sharma
added
area/ui
There was a problem hiding this comment.
Thanks @Mathanraj-Sharma! A few small comments from me, looks good otherwise.
explaining-ratings/src/app.py
Outdated
| await update_theme(q) | ||
| else: | ||
| del q.page['diff'] |
There was a problem hiding this comment.
What's the reason for including the rest of the handlers in an else block? Can it be flattened (else removed)?
There was a problem hiding this comment.
if they are not in else block when we switch them it resubmits the filters as well. So the rating diff also getting refreshed
There was a problem hiding this comment.
But if the same filters are applied again, shouldn't it result in the very same diff? In which case it doesn't matter if they are rerun or not.
There was a problem hiding this comment.
@mturoci no it doesn't, it creates different word clouds (as diff) for each time it gets triggered with the same filters
|
@mturoci I have improved the conditions to switch theme, please check |
Mathanraj-Sharma
force-pushed
the
mathan/fix/issue-77
branch
from
41d97cd
to
095e9fc
Compare
Fix #77