Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dark theme to Guess the Number app (neon) #107

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Conversation

Palani-SN
Copy link
Contributor

solves issue #76

  • Added separate zones for the card placements (justified them to center)
  • Added dark theme (neon) & toggle switch for theme control

Kindly review the changes, @mturoci

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Palani-SN! A few comments from me.

guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
@Palani-SN
Copy link
Contributor Author

Thanks @Palani-SN! A few comments from me.

I have made changes as per your inputs, Kindly have a look

@Palani-SN Palani-SN requested a review from mturoci October 8, 2022 11:19
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Palani-SN, getting better, but still some room for improvement.

guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
guess-the-number/guess_the_number/guess.py Outdated Show resolved Hide resolved
@Palani-SN
Copy link
Contributor Author

Thanks @Palani-SN, getting better, but still some room for improvement.

Sure, will make the required changes by today EOD,

Thank you,

@Palani-SN
Copy link
Contributor Author

Palani-SN commented Oct 10, 2022

Thanks @Palani-SN, getting better, but still some room for improvement.

I've made the changes, as per your inputs, kindly have a look.
image

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Palani-SN! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants