Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated UI of audio recording app #110

Merged
merged 2 commits into from
Oct 7, 2022
Merged

updated UI of audio recording app #110

merged 2 commits into from
Oct 7, 2022

Conversation

ashishlamsal
Copy link
Contributor

@ashishlamsal ashishlamsal commented Oct 3, 2022 •
edited by mturoci

Closes #109

@ashishlamsal
Copy link
Contributor Author

@mturoci can you please review this pull request.

mturoci
mturoci requested changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ashishlamsal! Just one change is needed and we are good to merge.

audio-recording/src/app.py Outdated Show resolved Hide resolved
@mturoci
Copy link
Collaborator

mturoci commented Oct 7, 2022

Note for future: If you put Closes #<issue-num> clause into the PR description, the GH will automatically link the issue to the PR and close it on merge.

@mturoci mturoci merged commit 5f544e9 into h2oai:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci Awaiting requested review from mturoci mturoci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve audio-recording app
2 participants
@ashishlamsal @mturoci