Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support python 3.10 runtime in apps #126

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

VijithaEkanayake
Copy link
Contributor

Fixes: #125

@VijithaEkanayake VijithaEkanayake added the area/core Core code related issue label Feb 14, 2024
@VijithaEkanayake VijithaEkanayake self-assigned this Feb 14, 2024
@VijithaEkanayake VijithaEkanayake force-pushed the feat/support-python-3.10 branch 6 times, most recently from ed4d6e4 to 48995ec Compare February 14, 2024 14:10
@VijithaEkanayake VijithaEkanayake force-pushed the feat/support-python-3.10 branch 3 times, most recently from de71042 to 8f205c4 Compare February 14, 2024 16:37
@@ -1,8 +1,9 @@
pandas==1.1.0
pygments==2.7.1
pandas==1.4.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we upgrade to the latest pandas 1.x (https://pypi.org/project/pandas/1.5.3/ ?)
and plan migration to pandas 2.x ?

pandas==1.1.0
pygments==2.7.1
pandas==1.4.0
Pygments==2.15.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,11 +1,12 @@
numpy==1.19.1
pandas==1.1.0
numpy==1.22.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numpy==1.19.1
pandas==1.1.0
numpy==1.22.2
pandas==1.4.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly==4.10.0
pygments==2.7.1
pygments==2.15.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,5 +1,11 @@
h2o_wave==0.20.0
certifi==2024.2.2
h2o_wave==0.26.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wave 1.0 introduces a breaking change for handle_on functionality. So Wave update needs to be handled separately.

pygments==2.7.1
certifi==2024.2.2
pandas==1.4.0
pygments==2.15.0
h2o-wave<1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wave 1.0 introduces a breaking change for handle_on functionality. So Wave update needs to be handled separately.

h11==0.11.0; python_version >= "3.6" and python_full_version >= "3.6.1"
certifi==2024.2.2
click==7.1.2
h11==0.11.0
h2o-wave<1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wave 1.0 introduces a breaking change for handle_on functionality. So Wave update needs to be handled separately.

pandas==1.1.0
pygments==2.7.1
pandas==1.4.0
Pygments==2.15.0
h2o-wave<1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wave 1.0 introduces a breaking change for handle_on functionality. So Wave update needs to be handled separately.

plotly==4.10.0
pygments==2.7.1
pygments==2.15.0
h2o-wave<1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wave 1.0 introduces a breaking change for handle_on functionality. So Wave update needs to be handled separately.

mnezh
mnezh previously approved these changes Feb 16, 2024
Copy link

@mnezh mnezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree on wave 1.0+
lgtm

@VijithaEkanayake VijithaEkanayake merged commit 3684d72 into main Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Core code related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make example apps ready for python 3.10
3 participants