Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor credit risk to use wave-ml #54

Closed
wants to merge 6 commits into from
Closed

Conversation

vopani
Copy link
Contributor

@vopani vopani commented Apr 22, 2021

Using Wave ML

Bare minimum refactoring to use wave-ml for modelling. There is more that can be done but this is a good place to start.
Part of #41

Have tested this locally ✅

cc: @mtanco @geomodular

credit-risk/src/config.py Outdated Show resolved Hide resolved
credit-risk/src/predictor.py Outdated Show resolved Hide resolved
@vopani vopani requested a review from geomodular May 1, 2021 13:26
@vopani vopani changed the title [WIP] Refactor credit risk to use wave-ml Refactor credit risk to use wave-ml May 10, 2021
@vopani
Copy link
Contributor Author

vopani commented May 10, 2021

@mtanco This is ready to be merged. Things to note:

  • Wave ML uses H2O-3 AutoML for modelling. Currently runtime set to 30 seconds - You can change this here

  • Doesn't use validation split nor does cross-validation (didn't find it necessary) but I could add it if required.

  • Models enabled are DRF, XGBoost and GBM. This is to ensure the local shapley contributions are supported.

@mtanco
Copy link
Contributor

mtanco commented May 14, 2021

@vopani : @g-eoj has refactored this in another branch to use native wave plots
@g-eoj : @vopani has refracted this here to use wave-ml instead of native h2o-3

Can you two make sure both of your PRs merge nicely, as both of these are needed for our users but there is some overlap. Thank you!!

@vopani
Copy link
Contributor Author

vopani commented May 14, 2021

Please merge @g-eoj 's code first and I will redo the WaveML part, it should be simple.

@g-eoj
Copy link
Contributor

g-eoj commented May 20, 2021

@vopani my PR is merged

@vopani vopani closed this May 21, 2021
@vopani vopani deleted the vopani/credit-risk-wave-ml branch May 21, 2021 05:42
@vopani
Copy link
Contributor Author

vopani commented May 21, 2021

Ooopps, deleted by mistake. Opened a new PR here: #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants