fix: prevent endless loop for multiple selections #2069

h2oai · Jul 19, 2023 · f7e87b5 · f7e87b5
1 parent 1a4e4ae
commit f7e87b5
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/ui/src/table.tsx b/ui/src/table.tsx
@@ -913,12 +913,12 @@ export const
         onSelectionChanged: () => {
           const selectedItemKeys = selection.getSelection().map(item => item.key as S)
           const args = wave.args[m.name] as S[]
-          if (args.length !== selectedItemKeys.length || args.some((item, idx) => item !== selectedItemKeys[idx])) {
-            wave.args[m.name] = selectedItemKeys
-            if (m.events?.includes('select')) wave.emit(m.name, 'select', selectedItemKeys)
-          }
+          if (isSingle && m.value === args[0] && m.value === selectedItemKeys[0]) return
+          if (isMultiple && m.values && m.values.every((item, idx) => item === selectedItemKeys[idx] && item === args[idx])) return
+          wave.args[m.name] = selectedItemKeys
+          if (m.events?.includes('select')) wave.emit(m.name, 'select', selectedItemKeys)
         }
-      }), [m.name, m.events]),
+      }), [m.name, m.value, m.values, m.events, isSingle, isMultiple]),
       computeHeight = () => {
         if (m.height) return m.height
         if (items.length > 10) return 500