New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toast notification alert message pop up #1007
Comments
@shanaka-rajitha We support native browser notifications which are superior to custom UI notifications since they show up even if user has not the tab / browser focused. Is there any hidden benefit in implementing these that I don't see maybe? |
The example provided in description is not the best UX for the outlined scenario. If the model creation is immediate, then user should be taken directly to the project / models page where the new model can be viewed which implies a successful operation. However, if the model creation takes longer the user is very likely to switch tab (since it is better than mindlessly stare at the app, just for the sake of waiting) which may result in missing the in-app notification, thus not getting the info about created the model. In this case native notification is superior as it can be seen even when the tab with the app is not focused currently. Either way, in-app notification is not a good fit. However, I agree there might be some usecases when in-app notification can be useful. Confirming settings were changed for example. The only thing that worries me is that this can be easily misunderstood / misused resulting in not that great UX of the apps. @lo5 proposed API for review: /**
* Snackbars are temporary in-app low importance notifications that inform user about
* a particular app state change and disappear on their own.
* Make sure you don't overuse them too much so as not to downgrade the UX of your app.
*/
interface Snackbar {
/** Snackbar's text. */
label: S
/** Snackbar's type based on scenario. Defaults to 'info'. */
type?: 'success' | 'info' | 'warning' | 'error'
/** If specified, renders a button next to the snackbar label. */
button?: Button
/** When should the snackbar disappear in 'ms'. Defaults to '5000'. */
timeout?: U
/** Specify where should the snackbar be. Defaults to 'top-right'. */
position?: 'top-right' | 'bottom-right' | 'bottom-center' | 'bottom-left' | 'top-left' | 'top-center'
/** The events to capture on this snackbar. */
events?: S[]
} |
Hi @mturoci, there is no issue as to what type of notification component is used. What is raised as a concern here is if browser native notifications can visually represent the information with a theme that implies the context of the message shown. By allowing the notification UI to be app-specific, provides a seamless experience to the user. To provide better UX we do not show all states of warning, information, alert, and success states in the same themeing. Hence why it is more important to show the notifications more visually related to the context than the type of notification used. |
I understand, what you are saying, but if the user doesn't see notification at all, there is no UX at all thus colors / theming is less important since it is just a cosmetic detail. It doesn't matter what color is the notification of if the user will not see it, right? I propose to give a deeper thought on general UX (how the user will actually use the feature) and less on UI (what colors he will (or will not) see). |
Including @mtanco @iamabhishekmathur |
I don't think it has to be one or the other. There are clear use cases for both, app native notification vs. browser native notification. In general, more sophisticated apps tend to use more of app native notifications, while newer/less evolved apps tend to use browser native notifications. Since browser notifications can be a temporary solution that can be used, I would decrease the priority of this ticket (app native notifications). @ShehanIshanka @sandruparo please use browser notifications for v1 of mlops app. let's not be blocked by this ticket. cc: @mtanco |
@mturoci - Re: API
|
We already have a
Sure
Sure, @shanaka-rajitha can you additionally design notifications for
Sure
The initial intention was to use existing
I would think yes if the routing achievable via button is considered optional, otherwise should be redirected right away after the action that triggered the notification and the notification will be used for decorative purposes without button. Wdyt @shanaka-rajitha ?
The reason I didn't propose a simple The |
Hi, @mturoci I have updated the rest of the designs for all other color variations, icons used are picked from Fluent icons. |
@mturoci So we have updated new toast layout as you can see and here if we are including an action button it better not to keep the toast as auto timeout. For the normal toast messages (ex:- project uploaded, saved successfully) we can have auto timeout. cc: @shanaka-rajitha |
@shihan007 got it, thanks |
Let's name this
What about adding a For consistency, would be good to also add |
Sounds good @lo5, I would just replace |
This will run into issues with the Python driver. |
Oh I see, thought it will only need a bit of frontend tweaks. Will explicitly point out that only buttons are supported unless there is a better solution, e.g. introducing Another question: Do we also want to support loading as described in the designs? If so, one option could be renaming @shanaka-rajitha @shihan007 where can I find the designs for Also what is the usecase for the Warning and error notifications use the same icon which is odd. Let's go with |
Progress so far: Screen.Recording.2021-09-28.at.12.43.39.PM.mov
|
@mturoci this looks great |
looks great @mturoci |
@dulajra @VijithaEkanayake These components are already built in the sdk and they will probably merge this soon. and will let you know once its done. |
@mturoci When can we get this ready in the Wave SDK? Can we use this toast as a floating component and form component as well? |
Probably by the end of January.
Toasts are floating components in general. For form, you can use existing |
Features
Design URL for specs : https://xd.adobe.com/view/809c4f44-9861-4f57-978a-e2d3515a426e-d5cf/screen/63ee7e10-a6aa-48a7-b9d9-fb78539eaf77/
Toast notification pop up (success state)
The text was updated successfully, but these errors were encountered: