Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification bar isn't visible over the side panel #1764

Closed
senalw opened this issue Dec 15, 2022 · 3 comments · Fixed by #1813
Closed

Notification bar isn't visible over the side panel #1764

senalw opened this issue Dec 15, 2022 · 3 comments · Fixed by #1813
Assignees
Labels
bug Bug in code good first issue Contributions welcome! ui Related to UI

Comments

@senalw
Copy link

senalw commented Dec 15, 2022

Wave SDK Version, OS

Wave SDK: 0.24.1, Wave Daemon: 0.24.1, OS: MacOs

Actual behavior

Notification bar is not appeared over the side panel when the side panel is active. Only can see after side panel is closed.

Screen.Recording.2022-12-15.at.17.09.58.mov

Expected behavior

It's required to show notification bar over the side panel.

Screenshot 2022-12-15 at 17 08 03

Steps To Reproduce

You can run the following code to create the issue:

@app('/')
async def serve(q: Q):
    if not q.client.initialized:
        # Create an empty meta_card to hold the notification bar
        q.page['meta'] = ui.meta_card(box='')
        # Display a button to show the notification bar
        q.page['form'] = ui.form_card(box='1 1 2 4', items=[
            ui.button(name="show_side_panel", label="Show side panel")
        ])
        q.client.initialized = True

    # Was the show_notification_bar button clicked?
    if q.args.show_notification_bar:
        # Create a notification bar
        q.page['meta'].notification_bar=ui.notification_bar(
            text='You can close me!',
            name="my_bar",
            # Get notified when the notification bar is dismissed.
            events=['dismissed'],
        )
    if q.args.show_side_panel:
        q.page["meta"].side_panel = ui.side_panel(
        title="",
        items=[ui.text("Side panel text"), ui.button(name='show_notification_bar', label='Show notification bar')],
        name="side_panel",
        events=["dismissed"],
        closable=True,
    )

    # Did we get events from the notification bar?
    if q.events.my_bar:
        # Was the notification bar dismissed?
        print("events triggered")
        if q.events.my_bar.dismissed:
            # Delete the notification bar
            print("dismissed")
            q.page['meta'].notification_bar = None

    if q.events.side_panel:
        if q.events.side_panel.dismissed:
            print("side panel dismissed")
            q.page["meta"].side_panel = None

    await q.page.save()
@senalw senalw added the bug Bug in code label Dec 15, 2022
@senalw senalw changed the title notification bar isn't visible over the side panel Notification bar isn't visible over the side panel Dec 15, 2022
@mturoci mturoci added ui Related to UI good first issue Contributions welcome! labels Dec 15, 2022
@MGreizis
Copy link

Hi! Is this still a relevant issue? As a first time contributor I'd like to take up this issue, as it is marked as "good first issue", if possible.

@dulajra
Copy link
Contributor

dulajra commented Jan 9, 2023

We observe this in wave 0.24.1 and I didn't see any development linked to this. MLOps wave app depends on this. @mturoci please prioritise this.

@mturoci
Copy link
Collaborator

mturoci commented Jan 9, 2023

@MGreizis please go ahead! :) Sorry for late notice, but I was out of office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code good first issue Contributions welcome! ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants