Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not render reserved title whitespace in vega_card if the title is empty #1923

Closed
bkos opened this issue Apr 11, 2023 · 4 comments · Fixed by #2146
Closed

Do not render reserved title whitespace in vega_card if the title is empty #1923

bkos opened this issue Apr 11, 2023 · 4 comments · Fixed by #2146
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@bkos
Copy link

bkos commented Apr 11, 2023

Even though the title is empty, in the vega_card there is still a whitespace rendered, which is just increasing unused space. This may be true for other cards as well.

Describe the solution you'd like

Do not render reserved title whitespace if the title is empty.
@bkos bkos added the feature Feature request label Apr 11, 2023
@mturoci mturoci added ui Related to UI good first issue Contributions welcome! labels Apr 12, 2023
@FahadYameen
Copy link

Hi @bkos , I am interested to resolve the issue. can I start working on this?

@bkos
Copy link
Author

bkos commented May 1, 2023

Hi @FahadYameen, as far as I'm concerned - sure, go for it 👌

@Mburnand-tech
Copy link

Hi @FahadYameen , Are you still working on this? I would like to give this ago - thanks

@Gingaaa
Copy link

Gingaaa commented Aug 20, 2023

Hey I have worked on around 7-8 company based project, but never countribute to open source this is my first time can you assign me this task.

MattiasOz added a commit to MattiasOz/wave that referenced this issue Sep 29, 2023
@MattiasOz
feat: removed reserved space for empty titles in vega_card h2oai#1923
7cba892
@MattiasOz MattiasOz mentioned this issue Sep 29, 2023
Merged
5 tasks
MattiasOz added a commit to MattiasOz/wave that referenced this issue Oct 2, 2023
@MattiasOz
feat: removed reserved space for empty titles in vega_card, simplified …
5146645 
…h2oai#1923
MattiasOz added a commit to MattiasOz/wave that referenced this issue Oct 2, 2023
@MattiasOz
feat: removed reserved space for empty titles in vega_card, version_3 h…
5311da0 
…2oai#1923
mturoci pushed a commit to MattiasOz/wave that referenced this issue Oct 3, 2023
@MattiasOz @mturoci
feat: removed reserved space for empty titles in vega_card h2oai#1923
657d6da
mturoci pushed a commit to MattiasOz/wave that referenced this issue Oct 3, 2023
@MattiasOz @mturoci
feat: removed reserved space for empty titles in vega_card, simplified …
553b9d7 
…h2oai#1923
mturoci pushed a commit to MattiasOz/wave that referenced this issue Oct 3, 2023
@MattiasOz @mturoci
feat: removed reserved space for empty titles in vega_card, version_3 h…
5d53392 
…2oai#1923
mturoci pushed a commit that referenced this issue Oct 3, 2023
@MattiasOz
feat: Remove reserved space for empty titles in vega_card #1923 (#2146)
f8fb86f
@marek-mihok marek-mihok mentioned this issue Oct 4, 2023
Merged
5 tasks
marek-mihok pushed a commit that referenced this issue Jan 15, 2024
@MattiasOz @marek-mihok
feat: Remove reserved space for empty titles in vega_card #1923 (#2146)
50f27c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: removed reserved space for empty titles in vega_card #1923 MattiasOz/wave
5 participants
@bkos @FahadYameen @mturoci @Mburnand-tech @Gingaaa