Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary button UI without label #2121

Closed
vopani opened this issue Aug 28, 2023 · 2 comments · Fixed by #2137
Closed

Primary button UI without label #2121

vopani opened this issue Aug 28, 2023 · 2 comments · Fixed by #2137
Assignees
Labels
bug Bug in code ui Related to UI

Comments

@vopani
Copy link
Contributor

vopani commented Aug 28, 2023

Wave SDK Version, OS

0.26.0 on MacOS

Actual behaviour

Button is not primary if label is not set.

Screenshot 2023-08-28 at 6 42 48 PM

eg: Button1 isn't primary.

Expected behaviour

Button1 should be primary.

Steps To Reproduce

from h2o_wave import main, app, Q, ui


@app('/demo')
async def serve(q: Q):
    q.page['example'] = ui.form_card(
        box='1 1 4 10',
        items=[
            ui.button(name='button1', icon='Search', primary=True),
            ui.button(name='button2', label='Search', icon='Search', primary=True)
        ])

    await q.page.save()
@vopani vopani added ui Related to UI bug Bug in code labels Aug 28, 2023
@mturoci
Copy link
Collaborator

mturoci commented Aug 28, 2023

Thanks @vopani! Does using an empty string for the label work as a workaround?

@vopani
Copy link
Contributor Author

vopani commented Aug 28, 2023

Thanks @vopani! Does using an empty string for the label work as a workaround?

No it doesn't. Output is same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants