Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Download ability to ui.command #2224

Closed
meganjkurka opened this issue Dec 12, 2023 · 0 comments · Fixed by #2262
Closed

Add Download ability to ui.command #2224

meganjkurka opened this issue Dec 12, 2023 · 0 comments · Fixed by #2262
Assignees
@marek-mihok
Labels
feature Feature request ui Related to UI

Comments

@meganjkurka
Copy link

In our documentation, we show making a ui.command that has the icon and label of "Download". This assumes that ui.command can perform the download function.

Can we add this ability to ui.command and other components where it would make sense?
@meganjkurka meganjkurka added the feature Feature request label Dec 12, 2023
@mturoci mturoci added the ui Related to UI label Dec 12, 2023
marek-mihok added a commit that referenced this issue Feb 6, 2024
@marek-mihok
feat: add download option for ui.command #2224
39445ba
marek-mihok added a commit that referenced this issue Feb 6, 2024
@marek-mihok
chore: add toolbar tests #2224
3bdcb79
marek-mihok added a commit that referenced this issue Feb 7, 2024
@marek-mihok
chore: add card_menu tests #2224
4257def
marek-mihok added a commit that referenced this issue Feb 7, 2024
@marek-mihok
chore: add button tests #2224
f8f9431
marek-mihok added a commit that referenced this issue Feb 8, 2024
@marek-mihok
chore: add table tests, update other tests #2224
00e5be9
marek-mihok added a commit that referenced this issue Feb 8, 2024
@marek-mihok
chore: update docs and example #2224
bd7d2bf
marek-mihok added a commit that referenced this issue Feb 8, 2024
@marek-mihok
chore: refactor #2224
dce343d
@marek-mihok marek-mihok mentioned this issue Feb 8, 2024
Merged
5 tasks
marek-mihok added a commit that referenced this issue Feb 8, 2024
@marek-mihok
chore: refactor button test #2224
07a7e91
marek-mihok added a commit that referenced this issue Feb 8, 2024
@marek-mihok
chore: fix card_menu test #2224
6712a47
marek-mihok added a commit that referenced this issue Feb 9, 2024
@marek-mihok
chore: get rid of ambiguous test naming #2224
b953544
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
feat: add download option for ui.command #2224
ca246d4
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: add toolbar tests #2224
2130812
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: add card_menu tests #2224
6b4fccf
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: add button tests #2224
deda06f
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: add table tests, update other tests #2224
ad44ba6
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: update docs and example #2224
941b8f5
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: refactor #2224
8bda415
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: refactor button test #2224
b9a3ea7
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: fix card_menu test #2224
dbde446
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok @mturoci
chore: get rid of ambiguous test naming #2224
aff0781
mturoci pushed a commit that referenced this issue Feb 9, 2024
@marek-mihok
feat: Make ui.command to support path and download props #2224 (#2262)
cd469fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marek-mihok marek-mihok

Labels
feature Feature request ui Related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Make ui.command to support path and download props #2224 h2oai/wave
3 participants
@meganjkurka @marek-mihok @mturoci