Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort is not working for table custom groups #2268

Closed
marek-mihok opened this issue Feb 15, 2024 · 3 comments · Fixed by #2274
Closed

Sort is not working for table custom groups #2268

marek-mihok opened this issue Feb 15, 2024 · 3 comments · Fixed by #2274
Labels
bug Bug in code ui Related to UI

Comments

@marek-mihok
Copy link
Contributor

Wave SDK Version, OS

Wave 1.0.2
MacOS 14.2.1
Chrome Version 120.0.6099.216 (Official Build) (arm64)

Actual behavior

Screen.Recording.2024-02-15.at.14.24.21.mov

Sort is not working properly when custom groups are specified as seen on the recording. Not only the wrong items are shown in the second group, but new rows are being added when sorting repeatedly.

Expected behavior

Rows to be sorted ascending (on first sort click and descending on second) within the group.

image

Steps To Reproduce

from h2o_wave import main, app, Q, ui


@app('/demo')
async def serve(q: Q):
    q.page['form'] = ui.form_card(box='1 1 -1 6', items=[
        ui.table(
            name='issues',
            columns=[ui.table_column(name='text', label='Issues reported by', sortable=True)],
            groups=[
                ui.table_group("Bob", [
                    ui.table_row(name='row1', cells=['Issue1']),
                    ui.table_row(name='row2', cells=['Issue2'])
                ]),
                ui.table_group("John", [
                    ui.table_row(name='row3', cells=['Issue3']),
                    ui.table_row(name='row4', cells=['Issue4']),
                    ui.table_row(name='row5', cells=['Issue5']),
                ], collapsed=False),
                ui.table_group("Jane", [])],
            height='500px'
        )
    ])
    await q.page.save()
@marek-mihok marek-mihok added ui Related to UI bug Bug in code labels Feb 15, 2024
@elipappas
Copy link

I am looking to contribute for the first time, is this still available?

@marek-mihok
Copy link
Contributor Author

@elipappas sure, it is! Feel free to assign yourself to this issue.

@marek-mihok
Copy link
Contributor Author

@elipappas due to high priority of this bug being fixed until the upcoming release it was fixed by our team. Feel free to assign yourself into any of other issues. We advise, especially for the first time contributors, to choose one labeled as Good first issue - you can find it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants