Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h2oai.github.io/wave/docs/examples dead links #413

Closed
0100101001010000 opened this issue Dec 18, 2020 · 3 comments · Fixed by #414
Closed

h2oai.github.io/wave/docs/examples dead links #413

0100101001010000 opened this issue Dec 18, 2020 · 3 comments · Fixed by #414
Labels
bug Bug in code docs Documentation
Milestone

Comments

@0100101001010000
Copy link

h2oai.github.io/wave/docs/examples links are dead, for example if you click on Hello World! the link it targets is:

https://h2oai.github.io/wave/docs/examples/examples/hello-world

however the actual link seems to be:

https://h2oai.github.io/wave/docs/examples/hello-world

seems like you've got an extra examples in the href that shouldn't be there.

Minor UX issue but the more people look at your product the more important it'll get :)

@0100101001010000 0100101001010000 added the bug Bug in code label Dec 18, 2020
@shaz13
Copy link

shaz13 commented Dec 18, 2020

The link - https://h2oai.github.io/wave/docs/examples/hello-world/ works fine for me.

@mturoci
Copy link
Collaborator

mturoci commented Dec 18, 2020

Thanks for reporting the issue @0100101001010000!

@mturoci mturoci added the docs Documentation label Dec 18, 2020
@lo5
Copy link
Member

lo5 commented Dec 18, 2020

Hmm. This happens if you directly go to https://h2oai.github.io/wave/examples and then click on an example, because an extra / gets slapped on automatically.

If you directly go to https://h2oai.github.io/wave and then click on Gallery, the examples works fine.

We'll have to dig deeper what's going on with our Docusaurus build.

@lo5 lo5 added this to the 0.11 milestone Dec 18, 2020
@lo5 lo5 closed this as completed in #414 Dec 21, 2020
lo5 pushed a commit that referenced this issue Dec 21, 2020
…#414)

* fix(docs): remove extra /examples from gallery link #413

* feat: use baseURL hook to keep links working both local and hosted env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code docs Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants