Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Notify about client disconnect. #2001

Merged
merged 2 commits into from May 31, 2023
Merged

feat: Notify about client disconnect. #2001

merged 2 commits into from May 31, 2023

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented May 31, 2023 •
edited

Required by #1979 as it spawns a new Wave app process per client and needs to perform proper clean up.

@mturoci mturoci requested a review from lo5 as a code owner May 31, 2023 12:55
lo5
lo5 approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@lo5 lo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mturoci!

@mturoci mturoci merged commit 918288b into master May 31, 2023
2 checks passed
@mturoci mturoci deleted the feat/client-disconnect branch May 31, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo5 lo5 lo5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mturoci @lo5