Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow keeping unresponsive apps. #2050

Merged
merged 3 commits into from Jun 29, 2023
Merged

feat: Allow keeping unresponsive apps. #2050

merged 3 commits into from Jun 29, 2023

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented Jun 29, 2023 •
edited

Implementation of #2035 (comment).

Closes #2043

@mturoci mturoci requested a review from lo5 as a code owner June 29, 2023 13:20
@mturoci mturoci requested a review from geomodular June 29, 2023 13:20
@mturoci mturoci changed the base branch from master to main June 29, 2023 13:22
@mturoci mturoci mentioned this pull request Jun 29, 2023
Closed
lo5
lo5 requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@lo5 lo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can change the env var to something shorter, e.g. H2O_WAVE_KEEP_APP_ALIVE, default to false.

Other than that, looks good - thanks @mturoci!

@mturoci mturoci merged commit 226af9a into main Jun 29, 2023
2 checks passed
@mturoci mturoci deleted the feat/allow-keeping-unresponsive-apps branch June 29, 2023 13:51
marek-mihok pushed a commit that referenced this pull request Jan 15, 2024
@mturoci @marek-mihok
feat: Allow keeping unresponsive apps. #2043 (#2050)
544456d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo5 lo5 lo5 requested changes

@geomodular geomodular Awaiting requested review from geomodular

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wave app being dropped when there's a request failure between Waved and the app
2 participants
@mturoci @lo5