Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trim trailing dash in api docs #2112 #2145

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix: Trim trailing dash in api docs #2112 #2145

merged 2 commits into from
Oct 2, 2023

Conversation

marek-mihok
Copy link
Contributor

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Screen.Recording.2023-09-26.at.15.26.55.mov

Closes #2112

mturoci
mturoci previously approved these changes Oct 2, 2023
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok! Please add an explanation comment on why the span is needed so that it's not accidentally removed in the future.

@mturoci mturoci merged commit 4d527f0 into main Oct 2, 2023
2 checks passed
@mturoci mturoci deleted the feat/issue-2112 branch October 2, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API hrefs not generated properly
2 participants