Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow using "idx" as field name in plot data. #2153

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented Oct 5, 2023

@marek-mihok - can you make a code review and a thorough QA to check if everything works as expected?

Copy link
Contributor

@marek-mihok marek-mihok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all of our plot examples and it seems everything is plotted correctly. However, I left you one comment regarding events, please check it out.

ui/src/plot.tsx Outdated Show resolved Hide resolved
mturoci and others added 2 commits October 9, 2023 08:58
@mturoci mturoci force-pushed the feat/allow-using-idx-in-plot-data branch from 9c1232b to 43354c5 Compare October 9, 2023 06:58
@mturoci mturoci merged commit 42008b7 into main Oct 9, 2023
2 checks passed
@mturoci mturoci deleted the feat/allow-using-idx-in-plot-data branch October 9, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants