New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve markdown typography #2179 #2189
Conversation
@marek-mihok there is no need to add the whole Tailwind. The issue talks about adding only styles from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marek-mihok!
- Can you please add an example with all the markdown elements for a side by side comparison?
- Seems like the new styles are pretty spacious. Let's add
compact
attribute defaulting totrue
to toggle this behavior. - Can the added CSS be loaded dynamically (only when markdown card is actually used)?
I've updated the existing example with side by side comparison. Please let me know if it is fine.
Done ✅
Done ✅ @mturoci since this is a visual change, do we need tests checking if proper styling is applied when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marek-mihok.
since this is a visual change, do we need tests checking if proper styling is applied when compact=False?
You already added one in markdown.md#compact
.
3d0409b
to
b8804cb
Compare
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.This change allows using
compact=False
attribute to toggle on a modern, well-structured and reader-friendly markdown look!Screen.Recording.2023-11-14.at.10.32.24.mov
Updated API is as follows:
In addition, this PR fixes an issue where there was a conflict when using multiple markdown cards on the same page.
Closes #2179