Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Go to the latest, update deps. #2302

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented Mar 27, 2024

Closes #2294
Closes #2235

@mturoci
Copy link
Collaborator Author

mturoci commented Mar 27, 2024

@marek-mihok please do a bit of QA to verify all works as expected. E2E and integration tests passed for me locally, but feel free to verify those as well.

@marek-mihok
Copy link
Contributor

@mturoci everything works as it should! This is what I did:

  • ran every command that uses go in Makefile
  • went through all examples
  • ran make release locally
  • installed and ran waved binary created in release process
  • ran e2e and integration tests

However I was running Cypress for the first time and got 2 failing tests. Are these expected?
image

image

@mturoci
Copy link
Collaborator Author

mturoci commented Mar 28, 2024

I was running Cypress for the first time and got 2 failing tests. Are these expected?

These are leftover dummy tests. Can be removed in subsequent PR.

@mturoci
Copy link
Collaborator Author

mturoci commented Apr 2, 2024

@codyharris-h2o-ai confirmed the ECR scans no longer report the vulnerabilities specified in the corresponding issue.

@mturoci mturoci merged commit f4394d9 into main Apr 2, 2024
2 checks passed
@mturoci mturoci deleted the chore/issue-2294 branch April 2, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve High Severity Vulnerabilities Go Version '1.19.4' has a (minor) security issue
2 participants