Remove constant heap allocations and deallocations when using WriteList.

h33p · Oct 5, 2018 · 03e1249 · 03e1249
1 parent 2a22be6
commit 03e1249
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/hlapi/hlapi.h b/hlapi/hlapi.h
@@ -9,6 +9,7 @@
 #include <stdexcept>
 #include <string.h>
 #include <vector>
+#include <algorithm>
 
 class VMException : public std::exception
 {
@@ -146,13 +147,14 @@ class WriteList
 	template<typename T>
 	void Write(uint64_t address, T& value)
 	{
-		T* copy = (T*)malloc(sizeof(T));
-		*copy = value;
-		writeList.push_back({(uint64_t)copy, address, sizeof(T)});
+		writeList.push_back({(uint64_t)buffer.size(), address, sizeof(T)});
+		buffer.reserve(sizeof(T));
+		std::copy((char*)&value, (char*)&value + sizeof(T), std::back_inserter(buffer));
 	}
 
   private:
 	std::vector<RWInfo> writeList;
+	std::vector<char> buffer;
 	WinCtx* ctx;
 	WinProc* proc;
 };

diff --git a/hlapi/winprocess.cpp b/hlapi/winprocess.cpp
@@ -37,12 +37,15 @@ void WriteList::Commit()
 
 	RWInfo* infos = writeList.data();
 
-	VMemWriteMul(&ctx->process, proc->dirBase, infos, sz);
+	uint64_t bufmem = (uint64_t)buffer.data();
 
 	for (size_t i = 0; i < sz; i++)
-		free((void*)infos[i].local);
+		infos[i].local += bufmem;
+
+	VMemWriteMul(&ctx->process, proc->dirBase, infos, sz);
 
 	writeList.clear();
+	buffer.clear();
 }
 
 WinDll* WinProcess::GetModuleInfo(const char* moduleName)