Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to remeber last selected path for download/upload #320

Merged
merged 2 commits into from
Aug 30, 2019

Conversation

wacki4
Copy link
Contributor

@wacki4 wacki4 commented Aug 11, 2019

I've many times upload/download many files multiple time, even between servers. Getting throught each folder was annoing - so i've added possibility to remember last path while until restart.

@cschindl
Copy link
Collaborator

Hi @wacki4,

nice to hear from you again. As I see, you were once again very diligent. The idea to save the path is very good, because it is the normal behavior of the operating system. I therefore think that we can omit the configuration option and always save the last path temporarily. At the next upload/download it is enough to check if the path still exists. If so, it can be used again. Otherwise we change to the default path. What do you think?

@wacki4
Copy link
Contributor Author

wacki4 commented Aug 12, 2019

I've made is as settings - cause maybe some people would like to open only default path. Still easy, but giving more possibilites of work :) If You thing that last path should be always - i don't have any others thoughts other that above. It would be still great ;)

@cschindl
Copy link
Collaborator

I think the last path should always be used. Too many configuration options confuse most people. Since the behavior would then be identical to the operating system, I think most people will not miss the configuration.

@wacki4
Copy link
Contributor Author

wacki4 commented Aug 13, 2019

So remove config parameter? Or You will do it on merging ? ;)

@cschindl
Copy link
Collaborator

Please remove the configuration parameters. I want to make sure I don't make any mistakes when merging.

@wacki4
Copy link
Contributor Author

wacki4 commented Aug 13, 2019

Done ;)

@cschindl cschindl changed the base branch from master to development August 30, 2019 15:53
@cschindl cschindl merged commit 1c088e0 into h3imdall:development Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants