Fix Whalebird font stack #732
Conversation
(this breaks emoji rendering too!)
src/renderer/App.vue
Outdated
| @@ -74,7 +74,7 @@ html, body, #app { | |||
| background-color: #d9e1e8; | |||
| } | |||
|
|
|||
| --specified-fonts: 'Noto Sans', 'Noto Sans CJK JP', 'Takaoゴシック', 'Hiragino Kaku Gothic ProN', 'ヒラギノ角ゴ ProN W3', Meiryo, メイリオ, Osaka, 'MS PGothic', arial, helvetica, sans-serif; | |||
| --specified-fonts: 'Noto Sans', 'Noto Sans CJK JP', 'Takaoゴシック', 'ヒラギノ角ゴ ProN W3', '-apple-system', 'BlinkMacSystemFont', 'Segoe UI', 'Roboto', 'Helvetica Neue', 'Apple Color Emoji', 'Segoe UI Emoji','Segoe UI Symbol'; | |||
There was a problem hiding this comment.
[stylelint] posted by Sider
Expected single space after "," in a single-line list (value-list-comma-space-after)
| @@ -319,7 +319,6 @@ export default { | |||
| resize: none; | |||
| height: 120px; | |||
| transition: border-color 0.2s cubic-bezier(0.645, 0.045, 9.355, 1); | |||
| font-family: 'Lato', sans-serif; | |||
There was a problem hiding this comment.
Hmm... The reason of Lato is a bug of Noto Sans.
Noto Sans could not render backticks properly, so I have set Lato.
#382
There was a problem hiding this comment.
Found the issue, but I can't reproduce it. My Noto Sans version is 2.0 (courtesy of TeX Live). Perhaps it's been updated?
There was a problem hiding this comment.
I still reproduce it on my computer.
There was a problem hiding this comment.
I can reproduce it too only with the embedded version in Whalebird.
Noto Sans 2.x works correctly.
There was a problem hiding this comment.
Oh, I see, thank you.
I'll update Noto Sans in Whalebird.
This pull request removes some Japanese and Western language fonts that break emoji composition. I've also removed Lato from the New Toot modal for the same reasons.
Additionally, I've added Bootstrap's font stack as a fallback.
Fixes #708.