Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean translation #819

Merged
merged 3 commits into from
Jan 11, 2019
Merged

Update Korean translation #819

merged 3 commits into from
Jan 11, 2019

Conversation

Canorus
Copy link
Contributor

@Canorus Canorus commented Jan 9, 2019

Description

Update for Korean translation. My apologies for delayed update.

Related Issues

NA

Appearance

NA

@Canorus
Copy link
Contributor Author

Canorus commented Jan 9, 2019

Just one thing. I directly modified the contents in /src/config/locales/ko/translation.missing.json and just left them out there. If I should have moved those contents into translation.json please just let me know.

@h3poteto
Copy link
Owner

h3poteto commented Jan 9, 2019

Thank you.

If I should have moved those contents into translation.json please just let me know.

Yes, could you move those contents into translation.json?
I am using translation.missing.json to write alternative text when I can't translate the words.

@Canorus
Copy link
Contributor Author

Canorus commented Jan 11, 2019

Items are merged into translation.json. Thanks.

@h3poteto h3poteto merged commit 57abf29 into h3poteto:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants