Fixed callable check on addProvider #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4cc
added a commit
that referenced
this pull request
Apr 13, 2015
Fixed callable check on addProvider
|
Thanks for reporting and fixing that bug! |
|
Thank you. My bad, I didn't fix the test entirely due to a change I did in Alice |
|
By the way, any chance to tag this modification? Thanks |
|
Thanks for that reminder. Done: https://github.com/h4cc/AliceFixturesBundle/releases/tag/0.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Alice function
addProvideris never being called in FixturesManager because always resolves to false due to the interface ofis_callablefunction is wrong used