Added JSCS & JSHint with Travis CI config

[ShashankaNataraj]

This PR fixes #314

• .jshintrc
  • Put brakes { after rule declarations/function name/while/for/etc. curly:true
• .jscsrc (Each completed task here has the corresponding jshint rule listed in code blocks)
  • Use two space indent "validateIndentation": 2
  • Put spaces between rule declarations/function name/while/for/etc and brakes {.requireSpacesInAnonymousFunctionExpression,requireSpacesInCallExpression,requireSpacesInConditionalExpression,requireSpacesInForStatement,requireSpacesInFunctionDeclaration,requireSpacesInFunctionExpression,requireSpacesInFunction,requireSpacesInNamedFunctionExpression
  • Put spaces after : in property declarations/objects definitions. "requireSpaceAfterObjectKeys": true
  • Use Spaces after and before ( and ) and [ and ]. "requireSpacesInsideParentheses":"all","requireSpacesInsideArrayBrackets": "all"
  • Use Spaces after and before = assigning values. "requireSpaceAfterBinaryOperators":["="],"requireSpaceBeforeBinaryOperators":["="]
  • Don't use spaces after unary operators such as ! or ++. "disallowSpaceAfterPrefixUnaryOperators":["++", "--", "+", "-", "~", "!"]
  • Use space after , in arguments variable. "validateParameterSeparator":", "
  • Declaring Objects using multi-line. "requireMultipleVarDecl":true
  • Declaring variables using multi-line. "requireMultipleVarDecl":true
  • Always use semicolons ;. "requireSemicolons":true
  • put spaces after double slash. ("requireSpaceAfterLineComment":true)
  • Any , must not have preceding space "disallowSpaceAfterBinaryOperators":[","],
  • Use $ in front of a variable if it's a jquery object. requireDollarBeforejQueryAssignment:true
  • General guidelines
    • "disallowMixedSpacesAndTabs": true
    • "disallowMultipleSpaces":true
    • "disallowTrailingComma":true
    • "requireLineFeedAtFileEnd":true

Style guidelines which do not have jshint / jscsc equivalents:

• When chained methods make long lines, divide each method on mutiple lines. Issue raised with JSCS
• Use double slash // for comments block Issue raised with JSCS
• ; must not have preceding space. Issue raised with JSCS

[ShashankaNataraj]

@arthurvr @grayghostvisuals @benschwarz @wellingguzman Please review 🎱

[arthurvr]

@arthurvr @grayghostvisuals @benschwarz @wellingguzman Please review 🎱

No real need for such comments. We're all busy and will try to get to this as soon as possible.

[ShashankaNataraj]

@arthurvr no offense intended with the mention. Will make changes.

[ShashankaNataraj]

Heres a new checklist of action after review

• .travis.yml
  • Update NodeJS version in .travis.yml
  • Change .travis.yml to invoke npm test instead of grunt quality
• Gruntfile.js
  • jshint:{ and jscs:{ require spaces after the colon
  • Lint the gruntfile and fix lint errors
  • grunt.registerTask('quality', ['jshint:all', 'jscs:all']); is missing spaces
  • jscs and jshint can be removed from packages.json as only the grunt tasks are required
  • Update NodeJS version

[arthurvr]

Also please squash your commits.

[arthurvr]

Should we consider dropping the current JavaScript style guide and going with an already-existing style guide? It's something else we don't have to maintain and honestly ours is pretty ugly and incomplete. Now is the right time to discuss it.

[arthurvr]

We also need a Travis CI badge in the readme.

[ShashankaNataraj]

@arthurvr I guess the Travis CI Badge can only be added by one of the core contributors on h5bp, since if anyone else adds it itll point to their builds.

I will wait for further discussions before proceeding further regarding the code style.

[arthurvr]

I guess the Travis CI Badge can only be added by one of the core contributors on h5bp, since if anyone else adds it itll point to their builds.

No, you can perfectly just edit the link address to point to our repo :p

[ShashankaNataraj]

ok :) will do. In general isn't jQuery's coding style considered pretty mature?

[arthurvr]

In general isn't jQuery's coding style considered pretty mature?

Define "mature"?

jQuery's code style guide is pretty ugly in my opinion but it's to the @h5bp/effeckt-css team to decide this.

[ShashankaNataraj]

mature is generally accepted and followed widely?

[wellingguzman]

We can reestablish the code guideline, there's probably are some not common things there, since I wrote what I've used by that time as the guideline.

Please you should squash those commits, Getting-Started Wiki so that way would be easier to git bisect, or track changes.

[ShashankaNataraj]

@wellingguzman Will squash my commits when I get time later today :)

[arthurvr]

We can reestablish the code guideline, there's probably are some not common things there, since I wrote what I've used by that time as the guideline.

Yeah, we should really revision it.

[ShashankaNataraj]

Can we revision the code guideline first and then revise this PR with changes? Because it looks like efforts on this PR will not be complete without the code guidelines being revised.

[arthurvr]

Can we revision the code guideline first and then revise this PR with changes? Because it looks like efforts on this PR will not be complete without the code guidelines being revised.

We can always land the grunt configs and discussion revision of the style guide later on.

[ShashankaNataraj]

ok I will be doing the grunt and the JSCS config first and raising a PR.

[Romainpetit]

@ShashankaNataraj Is this ever going to be completed ?

[ShashankaNataraj]

@Romainpetit Don't think so my friend. I lost interest in this a long time back

[naeluh]

@ShashankaNataraj What needs to be completed , I be happy to work on this ?

[ShashankaNataraj]

@naeluh @Romainpetit Snarky comments from the maintainers of this project put me off from completing this PR. Now, Im going to unsubscribe from this thread and let this PR rot.

Aidos.