Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding correct lang codes! #809

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Adding correct lang codes! #809

merged 2 commits into from
Sep 13, 2023

Conversation

roblarsen
Copy link
Member

This has driven me crazy forever. We have 30 translations and.... they were all lang="en" which made me sad.

@roblarsen
Copy link
Member Author

As a note, this is totally a hack. The documentation for Eleventy indicates one way of doing this that is much cleaner, but it didn't work and I don't care to chase the correct solution down. I would prefer to just get the correct language codes on these pages and be done with it.

@roblarsen
Copy link
Member Author

closes #744

@roblarsen roblarsen merged commit bc4b1c9 into main Sep 13, 2023
2 checks passed
@roblarsen roblarsen deleted the eleventy branch September 13, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant