Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unneeded IE11 specific docs and tidy-up #2781

Merged
merged 1 commit into from Jun 7, 2022

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 7, 2022

Partial fix for #2773. I'll make a separate PR later to remove browserconfig.xml

  • Removes unneeded IE11 specific docs
  • update docs about search plugins, and update URL (the google search results were not helpful so instead link to MDN)
  • Remove dated Chrome Mobile web apps link - the <meta name="mobile-web-app-capable" content="yes"> meta tag is no longer recommended. (REF: https://web.dev/learn/pwa/web-app-manifest/#designing-your-pwa-experience )

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

- Removes unneeded IE11 specific docs
- update docs about search plugins, and update URL (the google search results were not helpful so instead link to MDN)
- Remove dated Chrome Mobile web apps link - the `<meta name="mobile-web-app-capable" content="yes">` meta tag is no longer recommended.  (REF: https://web.dev/learn/pwa/web-app-manifest/#designing-your-pwa-experience )
Copy link
Member

@roblarsen roblarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@roblarsen roblarsen merged commit b2d54a1 into main Jun 7, 2022
@roblarsen roblarsen deleted the remove-ie11-docs-and-tidyup branch June 7, 2022 15:30
@roblarsen roblarsen mentioned this pull request Jun 7, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants