Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gulp esm #2831

Merged
merged 5 commits into from Aug 10, 2022
Merged

Gulp esm #2831

merged 5 commits into from Aug 10, 2022

Conversation

roblarsen
Copy link
Member

@roblarsen roblarsen commented Aug 3, 2022 •
edited

closing #2824 which forces us to do something useful. Since ES modules are supported natively, we can get rid of babel and still use modern JS.

This PR:

  • removes babel as a dependency
  • changes the gulpfile and the two test scripts to be .mjs All three were already using import, etc. so the upgrade was actually pretty easy. The specific change was to fix all three scripts to be able to read json files
  • updates the eslintrc file to recognize the ability to do the above

@roblarsen roblarsen requested a review from coliff August 3, 2022 20:33
@roblarsen
Copy link
Member Author

@coliff this is good to go, I think.

@roblarsen roblarsen self-assigned this Aug 5, 2022
@roblarsen roblarsen mentioned this pull request Aug 5, 2022
Closed
@roblarsen roblarsen merged commit 3e14cdc into main Aug 10, 2022
@roblarsen roblarsen deleted the gulp-esm branch August 10, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliff coliff Awaiting requested review from coliff

Assignees

@roblarsen roblarsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@roblarsen