Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print links for table section #20

Merged
merged 1 commit into from Apr 13, 2019
Merged

Fix print links for table section #20

merged 1 commit into from Apr 13, 2019

Conversation

antleblanc
Copy link
Contributor

fix #19

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This pull request doesn't have any tests.

README.md Outdated
@@ -100,7 +100,7 @@ At printing time, these styles will:
that they should:

* ensure the table header (`<thead>`) is [printed on each page spanned by the
table](http://css-discuss.incutio.com/wiki/Printing_Tables)
table](https://www.smashingmagazine.com/2015/01/designing-for-print-with-css/#page-breaks)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this link covers everything we have here, does it? I wonder if there's something that is closer.

@roblarsen
Copy link
Member

Thanks! I think fixing this is a good idea. I don't think the article linked covers everything we do. I wonder if there's anything else we can link to in order to bolster this information.

@antleblanc
Copy link
Contributor Author

Thanks @roblarsen for your review.

I will search for other articles that's covers table header and let you decide which one sounds more appropriate in this case.

But what I found quite interesting about the Smashing Magazine article is that it covers multiple aspects about the print CSS.

@roblarsen
Copy link
Member

That article is interesting and it may be worth looking at the print section with fresh eyes. I just don't think we can swap out that link for the one we're replacing without further context.

@coliff what do you think about looking at the print section to see if there's something interesting we should be doing?

@coliff
Copy link
Member

coliff commented Apr 10, 2019

One suggestion for a quick and easy fix for the broken link is to simply link to the same page on the Wayback Machine archive:
https://web.archive.org/web/20180815150934/http://css-discuss.incutio.com/wiki/Printing_Tables

Agree with Rob that it would be worth looking into this again in more depth - that article was last updated in November 2004 (!)

@roblarsen
Copy link
Member

@antleblanc Do you want to follow @coliff's suggestion and just use the wayback machine for now? I think we can use this issue as a jumping off point to reevaluate the print section I appreciate the links 👍

@coliff coliff mentioned this pull request Apr 12, 2019
4 tasks
@antleblanc
Copy link
Contributor Author

@roblarsen I've applied the @coliff's suggestion.

@roblarsen
Copy link
Member

👍

@roblarsen roblarsen merged commit 28651d0 into h5bp:master Apr 13, 2019
@antleblanc antleblanc deleted the print-table-link branch April 14, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken URL for Printing Tables section
3 participants