New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix print links for table section #20
Conversation
README.md
Outdated
@@ -100,7 +100,7 @@ At printing time, these styles will: | |||
that they should: | |||
|
|||
* ensure the table header (`<thead>`) is [printed on each page spanned by the | |||
table](http://css-discuss.incutio.com/wiki/Printing_Tables) | |||
table](https://www.smashingmagazine.com/2015/01/designing-for-print-with-css/#page-breaks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this link covers everything we have here, does it? I wonder if there's something that is closer.
Thanks! I think fixing this is a good idea. I don't think the article linked covers everything we do. I wonder if there's anything else we can link to in order to bolster this information. |
Thanks @roblarsen for your review. I will search for other articles that's covers table header and let you decide which one sounds more appropriate in this case. But what I found quite interesting about the Smashing Magazine article is that it covers multiple aspects about the print CSS. |
That article is interesting and it may be worth looking at the print section with fresh eyes. I just don't think we can swap out that link for the one we're replacing without further context. @coliff what do you think about looking at the print section to see if there's something interesting we should be doing? |
One suggestion for a quick and easy fix for the broken link is to simply link to the same page on the Wayback Machine archive: Agree with Rob that it would be worth looking into this again in more depth - that article was last updated in November 2004 (!) |
@antleblanc Do you want to follow @coliff's suggestion and just use the wayback machine for now? I think we can use this issue as a jumping off point to reevaluate the print section I appreciate the links 👍 |
@roblarsen I've applied the @coliff's suggestion. |
👍 |
fix #19
Types of changes
Checklist:
This pull request doesn't have any tests.