Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts gulpfile to mjs #290

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Converts gulpfile to mjs #290

merged 4 commits into from
Jan 9, 2024

Conversation

roblarsen
Copy link
Member

This stemmed from the autoprefixer issue

dependabot bot and others added 3 commits December 1, 2023 16:47
Bumps [gulp-autoprefixer](https://github.com/sindresorhus/gulp-autoprefixer) from 8.0.0 to 9.0.0.
- [Release notes](https://github.com/sindresorhus/gulp-autoprefixer/releases)
- [Commits](sindresorhus/gulp-autoprefixer@v8.0.0...v9.0.0)

---
updated-dependencies:
- dependency-name: gulp-autoprefixer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
This fixes issues with the autoprefixer update as well
@roblarsen roblarsen requested a review from coliff December 4, 2023 17:35
@roblarsen roblarsen self-assigned this Dec 4, 2023
@roblarsen
Copy link
Member Author

Why did I not merge this? @coliff can you 👍

@coliff
Copy link
Member

coliff commented Jan 9, 2024

looks good and build completes successfully. we should really update the ESlint script to lint the mjs file though. Currently there is an error:

image

(related: we should really run eslint in the CI - in addition to Stylelint)

@roblarsen roblarsen merged commit 2527b51 into main Jan 9, 2024
5 checks passed
@roblarsen roblarsen deleted the convert-to-mjs branch January 9, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants