-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blank lines in print css and fix block comments. #31
Add blank lines in print css and fix block comments. #31
Conversation
Hey there - thanks for the PR! You're right - there should be a blank line between each rule before each rule - but I don't think a blank line is needed on line 8 (before the first rule) or 75 (after the last rule). |
c58e756
to
cdce593
Compare
I don't know what the policies are about updating the pull request but I figured that just force pushing seems the cleanest. |
thanks for updating that - the |
cdce593
to
f80e1a0
Compare
Apparently gulp 3 and node 12 don't go together. I had to resort to some docker trickery in order to run the build process. But it is done. :) |
Interesting! Maybe it's time we looked to update the script to Gulp 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I got a wierd error and ended up on [1], I did not look into it further, but using node 11.15.0 did just work. |
Great! time to test out my limited Gulp skills! |
Also, thanks! |
css files leave a blank line in between every block. But in
_print.css
this is not the case, which makes is less readable. The block comments in this file have extra whitespace at the beginning of consecutive lines which has been removed.