Improvement/remove odd label comments #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.clearfix
class has a comment explaining what the parts in the definition do, and why they are there. Each is labeled with a number. In the definition of the class the same numbers are used as labels but they are below the the line to which they apply.I find this very counter intuitive. I would understand it being on the same line, or on the line before
content
, but not on a separate line below it. Originally the label was trailing on the same line [1]. However I think the comment does a good enough job at explaining the definition without the labels.I see three possible solutions: putting them back where they where, putting them on the line above, or removing them altogether.
There is a similar situation in the definition of
.visuallyhidden
.ps: Block comments where missing a space before on consecutive lines, which I have added.
pps: The commit in [1] also seems to be the one where the block comments got mangled.
[1] h5bp/html5-boilerplate@e1e7277