Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to gulp 4 and update others gulp plugins #41

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Upgrade to gulp 4 and update others gulp plugins #41

merged 1 commit into from
Sep 29, 2019

Conversation

antleblanc
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This pull request was inspired by both:

@roblarsen
Copy link
Member

Thanks! I'll take a look at this tomorrow.

@roblarsen
Copy link
Member

Sorry it took so long. Testing was a little bit of an npm dance getting gulp to actually upgrade. Looks good to me. Thanks so much.

@roblarsen roblarsen merged commit 648ece2 into h5bp:master Sep 29, 2019
@antleblanc antleblanc deleted the patch-1 branch September 29, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants