Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli adds "content-language: br" #248

Closed
nlemoine opened this issue Oct 7, 2020 · 2 comments · Fixed by #249
Closed

Brotli adds "content-language: br" #248

nlemoine opened this issue Oct 7, 2020 · 2 comments · Fixed by #249
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nlemoine
Copy link
Contributor

nlemoine commented Oct 7, 2020

I recently started to serve brotli pre-compressed files. Works fine except that all files served have a content-language: br (brazilian) unwanted header.

I stumbled upon this post: https://blog.desgrange.net/post/2017/04/10/pre-compression-with-gzip-and-brotli-in-apache.html

The mime module seems to blame. Could you fix this by adding a RemoveLanguage .br directive?

@LeoColomb
Copy link
Member

Thanks for opening this issue @nlemoine!

Works fine except that all files served have a content-language: br (brazilian)

Really interesting case!
Did you actually see this behavior yourself?
What was your version?

Could you fix this by adding a RemoveLanguage .br directive?

Looks fair enough. Please open a PR! 🙂

@LeoColomb LeoColomb added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Oct 8, 2020
@nlemoine
Copy link
Contributor Author

nlemoine commented Oct 8, 2020

Did you actually see this behavior yourself?

Yes, I noticed it when setting up brotli pre compression but didn't pay attention. I stumbled upon this post for another reason and adding the fix.

What was your version?

Apache 2.4.34 (on a shared hosting)

While submitting the PR, I took a deeper look at this issue. This seems to be the regular behaviour of mod_mime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants