Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow and test storing a class #79

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Allow and test storing a class #79

merged 10 commits into from
Jan 31, 2024

Conversation

liamhuber
Copy link
Contributor

Closes #78

@larsoner
Copy link
Member

My initial reaction was to expect this to be complicated. But it looks like it's not too bad.

Would it be worth adding a few other classes, like maybe a couple builtins like datetime.datetime or similar? It would show us that it really should generalize to other stuff which is nice.

@liamhuber
Copy link
Contributor Author

My initial reaction was to expect this to be complicated. But it looks like it's not too bad.

🚀

Would it be worth adding a few other classes, like maybe a couple builtins like datetime.datetime or similar? It would show us that it really should generalize to other stuff which is nice.

Yes, I like that idea! I think one class from from the std lib and one builtin is probably sufficient. I'll push that shortly 😄

@larsoner larsoner merged commit 0b08ee0 into h5io:main Jan 31, 2024
6 checks passed
@larsoner
Copy link
Member

Thanks @liamhuber !

@liamhuber liamhuber deleted the store_classes branch January 31, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should it be possible to store a class?
2 participants