New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: dimension performance #196

Open

kmuehlbauer wants to merge 1 commit into h5netcdf:main from kmuehlbauer:dimension-performance

Collaborator

kmuehlbauer commented Dec 1, 2022

Closes Issue #xxxx
Tests added
Changes are documented in CHANGELOG.rst


          WIP: first take on speeding up dimensions

59d4db6

kmuehlbauer force-pushed the dimension-performance branch from e2a5c78 to 59d4db6 Compare

December 1, 2022 15:05

Collaborator Author

kmuehlbauer commented Dec 1, 2022

@hmaarrfk Could you please check this PR against your use-case in #195. I'm getting almost comparable timings with netCDF4 and h5netcdf.

kmuehlbauer mentioned this pull request

Improving performance for h5netcdf #195

Open

Contributor

hmaarrfk commented Dec 2, 2022

I think this is premature optimization. We should focus on making self._h5ds faster.

    def __len__(self):
        if self._phony:
            return self._size
        return self._h5ds.shape[0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment