HFP-3610 Do not change element position if already in dropzone #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otacke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged in, placing a draggable inside a dropbox using the "select" logic is ignored if the element is already inside the dropbox.
Currently it is possible that by accident a dropped item is auto-aligned in a dropzone that should not auto-align. Please compare the report at https://h5p.org/comment/47251.
This can happen if you
The keyboard select-function is triggered which will always auto-align items. I assume this is a side effect to the recent changes of drag detection (or has always been the case :-)).
By only placing a draggable inside a dropbox using the "select" logic if the element is not already inside the dropbox, the issue can be fixed while the rest of the behavior stays the same.