Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantics.json #33

Closed
wants to merge 1 commit into from
Closed

Update semantics.json #33

wants to merge 1 commit into from

Conversation

BV52
Copy link

@BV52 BV52 commented Mar 12, 2018

Removed option "Require user input before the solution can be viewed". This option does not do anything and has caused some confusion from users.

@timothyylim
Copy link
Contributor

Hi @BV52 , it seems like that setting is used here:

return !this.options.behaviour.showSolutionsRequiresInput || this.answered || this.blankIsCorrect;

This line means that an answer is given if any of the conditions are fulfilled:

  • It doesn't require input
  • It has not been answered
  • If the answer is meant to be blank

Could you try to see if the setting is still necessary? Thanks!

@BV52
Copy link
Author

BV52 commented Mar 22, 2018

Hi @timothyylim , I'm not really sure I fully understood what this line does. If it is some sort of trigger/test that requires a user input prior to showing showing then it is actually not doing anything since there isn't a show solution feature in DND. Furthermore I removed the line of code mentioned above in my div environment and have been testing it. So far nothing seems to be broken.

@fnoks fnoks closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants